Homec4science

Make error message from STDERR in exec channel

Authored by epriestley <git@epriestley.com> on Aug 10 2012, 20:36.

Description

Make error message from STDERR in exec channel

Summary:
If client prints to stderr then we fail horribly.
Our tests print to stderr quite often and there's not much I can do about it.
One example is when we throw in destructor (which is not supported by HPHP).

This is not ideal because message comes out of order.
I'll probably reorder STDERR before any input.

Test Plan:

fprintf(STDERR, 'Test.'); // From client.

Reviewers: vrana

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3213

Details

Committed
epriestley <git@epriestley.com>Aug 10 2012, 20:36
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU3f252cd21274: Support self::$foo case
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU496f67fdf66a: Make error message from STDERR in exec channel (authored by epriestley <git@epriestley.com>).Aug 10 2012, 20:36