Homec4science

Improve the stack traces from phlog($exception)

Authored by epriestley <git@epriestley.com> on Jun 4 2015, 20:49.

Description

Improve the stack traces from phlog($exception)

Summary:
Fixes T8331. When we throw an uncaught exception in Phabricator, it sometimes ends up getting phlog()'d.

The traces this function prints out are from the phlog() call, not the original exception. This reduces their diagnostic value significantly.

Since we can build reasonable compound stack traces for complex exceptions now, just create a complex exception (don't throw it) and use that stack instead.

Test Plan: Used this patch to get a reasonable stack for T8415.

Reviewers: joshuaspence, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8331

Differential Revision: https://secure.phabricator.com/D13150

Details

Committed
epriestley <git@epriestley.com>Jun 4 2015, 20:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUafc05a9a7f00: Linter fixes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU4a0e1b47a584: Improve the stack traces from phlog($exception) (authored by epriestley <git@epriestley.com>).Jun 4 2015, 20:49