Homec4science

Don't retry queries on connections holding global locks

Authored by epriestley <git@epriestley.com> on Apr 24 2016, 16:11.

Description

Don't retry queries on connections holding global locks

Summary:
Ref T10860. Currently, if we lose a connection that is holding a MySQL global lock, we may retry the query automatically.

Instead, we should abort, just like we do if we were in the middle of a transaction. Otherwise, code may still think it has the lock and do unsafe things.

Test Plan: See next revision.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10860

Differential Revision: https://secure.phabricator.com/D15789

Details

Committed
epriestley <git@epriestley.com>Apr 25 2016, 20:20
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU139d316c4484: Support query timeouts with mysqli on the client side
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU4b44d03ba60c: Don't retry queries on connections holding global locks (authored by epriestley <git@epriestley.com>).Apr 25 2016, 20:20