Homec4science

Remove "supportsStateParameter()" from generic OAuth2 code

Authored by epriestley <git@epriestley.com> on Feb 24 2014, 01:46.

Description

Remove "supportsStateParameter()" from generic OAuth2 code

Summary:
Depends on D8318. All providers must support this, or they can't be implemented securely. This is based on a very old reading of the GitHub instructions or something like that which didn't mention "state", but the provider supports it.

This has no impact at runtime because no provider has ever returned false from this method, nor would we ever implement a provider that did.

Test Plan: Grepped for callsites.

Reviewers: btrahan, arice

Reviewed By: arice

CC: chad, arice, aran

Differential Revision: https://secure.phabricator.com/D8319

Details

Committed
epriestley <git@epriestley.com>Feb 24 2014, 01:46
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5a9002ebed4f: Change "%s" in qsprintf to exclude non-BMP characters
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU4b5c4ad61e00: Remove "supportsStateParameter()" from generic OAuth2 code (authored by epriestley <git@epriestley.com>).Feb 24 2014, 01:46