Homec4science

Attempt to automatically build XHPAST.

Authored by Joshua Spence <josh@joshuaspence.com> on May 12 2014, 16:34.

Description

Attempt to automatically build XHPAST.

Summary: Fixes T4951. Whilst xhpast was originally intended to be an internal development tool, it is not unreasonable for ArcanistXHPASTLinter to be used externally. Currently, however, if the compiled version of xhpast is not up-to-date, we simply exit and ask the user to build XHPAST themselves. Instead, let's try to build XHPAST automatically.

Test Plan: Removed ./src/parser/xhpast/bin/xhpast and ran arc lint over a PHP file. Verified that the xhpast binary was created during this process.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4951

Differential Revision: https://secure.phabricator.com/D9076

Details

Committed
epriestley <git@epriestley.com>May 12 2014, 16:34
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU8ac1de09df40: Add phutil-library linter to libphutil
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU4b85681758d7: Attempt to automatically build XHPAST. (authored by Joshua Spence <josh@joshuaspence.com>).May 12 2014, 16:34