Homec4science

Add test coverage for PhutilErrorHandler and silence operator ("@")

Authored by epriestley <git@epriestley.com> on Jul 10 2013, 01:21.

Description

Add test coverage for PhutilErrorHandler and silence operator ("@")

Summary:
Fixes T3351. The situation is actually less dire than the comment implies, I had slightly misrembered context. Basically:

  • PhutilErrorHandler respects the silence operator ("@"); I'm not sure if it did at the time.
  • Part of the issue was stack traces for unrelated things, but PhutilOpaqueEnvelope solved that.

Test Plan:

  • Added test coverage for the beahvior of "@".
  • Hit LDAP exceptions and verified nothing sensitive appeared in the traces/logs.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3351

Differential Revision: https://secure.phabricator.com/D6390

Details

Committed
epriestley <git@epriestley.com>Jul 10 2013, 01:21
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUeb983ffce988: Fix remarkup "NOTE" block syntax
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU505b89b2b9c2: Add test coverage for PhutilErrorHandler and silence operator ("@") (authored by epriestley <git@epriestley.com>).Jul 10 2013, 01:21