Support class const dereferencing in xhpast
51c179b4c000
Actions

Authored by Richard van Velzen <rvanvelzen@experty.com> on Jun 17 2016, 11:50.

Description

Support class const dereferencing in xhpast

Summary:
Ref T4334. As it turns out, a major overhaul of the syntax wasn't needed.

This adds support for stuff like SomeClass::SOME_CONST[$idx] which was introduced in PHP 7.

Test Plan: Added a test case. Ran tests on libphutil and arcanist with both PHP 5 and PHP 7.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, Firehed

Maniphest Tasks: T4334

Committed

Richard van Velzen <rvanvelzen@experty.com>

Jun 17 2016, 14:11

Pushed

aubort

Mar 17 2017, 12:03

Parents

Branches

Unknown

Tags

Unknown

Richard van Velzen <rvanvelzen@experty.com> committed rPHU51c179b4c000: Support class const dereferencing in xhpast (authored by Richard van Velzen <rvanvelzen@experty.com>).Jun 17 2016, 14:11

				Path
	P			src/parser/xhpast/__tests__/data/php-array-dereference-4.test Copied from src/parser/xhpast/__tests__/data/php-literal-index.php.test
	M			src/parser/xhpast/bin/PhutilXHPASTBinary.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/xhpast.cpp