Homec4science

Slightly improve prose diffs for text ending in newlines or punctuation

Authored by epriestley <git@epriestley.com> on Jun 6 2016, 22:48.

Description

Slightly improve prose diffs for text ending in newlines or punctuation

Summary:
Ref T3353. Currently, if text ends in newlines (or some other types of punctuation) we generate an extra piece at the end which can muck up the algorithm.

Do a slightly better job with this.

Test Plan: Viewed a diff between "a\nb\nc\n" and "a\nb\nc\nd\n", got a cleaner diff out of it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T3353

Differential Revision: https://secure.phabricator.com/D16061

Details

Committed
epriestley <git@epriestley.com>Jun 6 2016, 23:01
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb3aa54fb9460: Very rough cut of prose diffs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU557309b9242a: Slightly improve prose diffs for text ending in newlines or punctuation (authored by epriestley <git@epriestley.com>).Jun 6 2016, 23:01