Homec4science

Make static linking of xhpast nondefault

Authored by epriestley <git@epriestley.com> on Mar 13 2012, 01:05.

Description

Make static linking of xhpast nondefault

Summary:
-static breaks builds on OSX:

ar -crs libxhpast.a astnode.o scanner.lex.o parser.yacc.o
/usr/bin/ranlib: file: libxhpast.a(astnode.o) has no symbols
g++ -fPIC -g -Wall -O3 -minline-all-stringops -static -o xhpast xhpast.cpp libxhpast.a
ld: library not found for -lcrt0.o
collect2: ld returned 1 exit status
make: *** [xhpast] Error 1

Since I think we only need static builds on FB/HPHP machines and we raise better errors now anyway, default to dynamic and provide a static option.

Test Plan: Ran build on OSX.

Reviewers: edward, hsb, btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T975

Differential Revision: https://secure.phabricator.com/D1858

Details

Committed
epriestley <git@epriestley.com>Mar 13 2012, 01:05
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU9be36db7f574: Improve SSL error message for cURL error 51 (CURLE_SSL_PEER_CERTIFICATE /…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU59a468143cf2: Make static linking of xhpast nondefault (authored by epriestley <git@epriestley.com>).Mar 13 2012, 01:05