Correctly support try..catch..finally in xhpast
5f573d2b7f27
Actions

Authored by Richard van Velzen <rvanvelzen@experty.com> on Mar 17 2016, 12:50.

Description

Correctly support try..catch..finally in xhpast

Summary: Ref T4334. The catch clauses are optional when a finally is available.

Test Plan: run xhpast with some files. Also added unit tests

Reviewers: joshuaspence, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: joshuaspence, epriestley, Korvin

Maniphest Tasks: T4334

Committed

Richard van Velzen <rvanvelzen@experty.com>

Mar 17 2016, 14:36

Pushed

aubort

Mar 17 2017, 12:03

Parents

Branches

Unknown

Tags

Unknown

Richard van Velzen <rvanvelzen@experty.com> committed rPHU5f573d2b7f27: Correctly support try..catch..finally in xhpast (authored by Richard van Velzen <rvanvelzen@experty.com>).Mar 17 2016, 14:36

				Path
	P			src/parser/xhpast/__tests__/data/php-only-finally.test Copied from src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test
	P			src/parser/xhpast/__tests__/data/php-try-no-catch-or-finally.test Copied from src/parser/xhpast/__tests__/data/base-fail-syntax.php.test
	M			src/parser/xhpast/bin/PhutilXHPASTBinary.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/xhpast.cpp