Homec4science

Preserve stdin/stdout when launching editor

Authored by Adam Hupp <ahupp@facebook.com> on Mar 6 2011, 00:03.

Description

Preserve stdin/stdout when launching editor

Summary:
emacsclient requires that stdin be attached to a real pty device.
PHP's passthru() and system() functions connect the child processes'
stdin and stdout to pipes to capture the output, breaking emacsclient.

This change fixes the issue by using proc_open which allows allows for
explicit control of the childs fds.

Blame Rev:

Task ID: #

Reviewers: epriestley

Test Plan:
I used it to submit this diff.

DiffCamp Revision:

Revert Plan:

Database Impact:

Memcache Impact:

Other Notes:

EImportant:

  • begin *PUBLIC* platform impact section -

Bugzilla: #

  • end platform impact -

Differential Revision: 51

Details

Committed
Adam Hupp <ahupp@facebook.com>Mar 6 2011, 00:42
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU2cb35ae1e486: Improve error message when Phabricator fails to load a class.
Branches
Unknown
Tags
Unknown

Event Timeline

Adam Hupp <ahupp@facebook.com> committed rPHU613e84e8d596: Preserve stdin/stdout when launching editor (authored by Adam Hupp <ahupp@facebook.com>).Mar 6 2011, 00:42