Homec4science

Convert E_RECOVERABLE_ERROR into RuntimeException

Authored by epriestley <git@epriestley.com> on Jun 5 2012, 15:46.

Description

Convert E_RECOVERABLE_ERROR into RuntimeException

Summary:
We currently treat typehint violations as warnings in normal use, and only raise InvalidArgumentException via assert_instances_of(). Instead, always raise InvalidArgumentException.

E_RECOVERABLE_ERRORs are always severe; raise them all as runtime errors.

Raise "use of undefined variable" as a runtime error, it is highly correlated with badness.

Test Plan: Ran a program with undefined variables and typehint problems.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2653

Details

Committed
epriestley <git@epriestley.com>Jun 5 2012, 15:46
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU421a28bc14f6: Fix comment
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU6294c9648fae: Convert E_RECOVERABLE_ERROR into RuntimeException (authored by epriestley <git@epriestley.com>).Jun 5 2012, 15:46