Homec4science

Use setters instead of public properties

Authored by Joshua Spence <josh@freelancer.com> on Nov 18 2015, 13:28.

Description

Use setters instead of public properties

Summary: Currently a bunch of properties in the AASTNode class are public instead of using explicit setter methods. This doesn't seem to have any effect on performance as far as I can tell

Test Plan:
Ran the following script with 100 iterators:

{P1892}

Before
Average: 2.679129s
Total:   267.912916s
After
Average: 2.648229s
Total:   264.822857s

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14504

Details

Committed
Joshua Spence <josh@freelancer.com>Nov 18 2015, 13:29
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU23edd1b1f443: Add previous and next sibling pointers to `AASTNode`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPHU67f26422b91a: Use setters instead of public properties (authored by Joshua Spence <josh@freelancer.com>).Nov 18 2015, 13:29