Homec4science

Lift class map construction into a new class map query

Authored by epriestley <git@epriestley.com> on Jun 23 2015, 19:21.

Description

Lift class map construction into a new class map query

Summary:
Ref T8637. The "load concrete subclasses" pattern has enjoyed wide success, but we're starting to collect a lot of instances of "loop over this list of things and make sure they all really have unique keys".

We can better support this, caching, subclass expansion, and sorting in a thin layer on top of PhutilSymbolLoader.

Test Plan: See next diff.

Reviewers: btrahan, joshuaspence

Reviewed By: btrahan, joshuaspence

Subscribers: epriestley

Maniphest Tasks: T8637

Differential Revision: https://secure.phabricator.com/D13391

Details

Committed
epriestley <git@epriestley.com>Jun 23 2015, 19:21
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU6fedd82a29a0: Minor tidying of PhutilSymbolLoader
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU74c9cb3a266e: Lift class map construction into a new class map query (authored by epriestley <git@epriestley.com>).Jun 23 2015, 19:21