Homec4science

Fix PhutilInteractiveEditor if the user's $EDITOR contains space

Authored by Jason Ge <jungejason@fb.com> on Mar 29 2012, 21:11.

Description

Fix PhutilInteractiveEditor if the user's $EDITOR contains space

Summary:
On linux if $EDITOR contains spaces, the editor will fail to launch. Use
%C instead of %s.

Test Plan:
arc diff works again with export EDITOR="/usr/bin/emacs -q"

Reviewers: epriestley, nh

Reviewed By: nh

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2055

Details

Committed
Jason Ge <jungejason@fb.com>Mar 29 2012, 21:33
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUdb9c7168ea13: Avoid double indenting in console wrapping
Branches
Unknown
Tags
Unknown

Event Timeline

Jason Ge <jungejason@fb.com> committed rPHU793a5f8622e9: Fix PhutilInteractiveEditor if the user's $EDITOR contains space (authored by Jason Ge <jungejason@fb.com>).Mar 29 2012, 21:33