Homec4science

Fix RemarkupEngine issues with header markup, restore unit tests

Authored by epriestley <epriestley@phabricator.com> on Mar 30 2011, 06:58.

Description

Fix RemarkupEngine issues with header markup, restore unit tests

Summary:
The header markup rule was pretty broken because of some changes I
made when porting this from trunk -- it would treat a very short header like
'=a=' as an h3, since we didn't break out of the loop, and fail entirely in
cases where we captured leading whitespace (this is an intentional change
to better accommodate certain parsers).

There were also some unit tests which I brought over but didn't actually hook
up. Hook those up and make the minor changes required to get them to pass.

Test Plan:
Ran the unit tests, looked at Maniphest content with header markup
in it.

Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen
CC: jungejason, epriestley
Differential Revision: 90

Details

Committed
epriestley <epriestley@phabricator.com>Mar 30 2011, 07:30
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUc12c698b17d4: Fix a non-HPHP issue with fclose()'ing pipes which we've already closed.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <epriestley@phabricator.com> committed rPHU7a405d87d45c: Fix RemarkupEngine issues with header markup, restore unit tests (authored by epriestley <epriestley@phabricator.com>).Mar 30 2011, 07:30