Homec4science

Fix profiling Conduit calls

Authored by Jakub Vrana <jakub@vrana.cz> on Feb 20 2013, 08:13.

Description

Fix profiling Conduit calls

Summary: This error was masked by resolving HTTPS futures in serial.

Test Plan:

PhutilServiceProfiler::getInstance()->enableDiscardMode();
$conduit = new ConduitClient('https://secure.phabricator.com/');
$futures = array(
  $conduit->callMethod('conduit.ping', array()),
  $conduit->callMethod('conduit.ping', array()),
);

Futures($futures)->resolveAll();

Didn't see:

Notice: Undefined offset: 2 in libphutil/src/serviceprofiler/PhutilServiceProfiler.php on line 42

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5027

Details

Committed
Jakub Vrana <jakub@vrana.cz>Feb 20 2013, 18:03
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUcea0499b1398: Do not calculate checksums of directories.
Branches
Unknown
Tags
Unknown

Event Timeline

Jakub Vrana <jakub@vrana.cz> committed rPHU803296e55ce6: Fix profiling Conduit calls (authored by Jakub Vrana <jakub@vrana.cz>).Feb 20 2013, 18:03