Homec4science

use parse_url() for URI parsing

Authored by Wez Furlong <wez@fb.com> on Apr 18 2013, 00:24.

Description

use parse_url() for URI parsing

Summary:
We periodically have an issue with really long URLs hitting a
pcre backtracking limit (hhvm has a low limit configured due to historical
reasons). Avoiding PCRE in the URL parser seems like a good idea.

Test Plan:
arc unit passes, but with the caveat that I've only run this
on hhvm so far; will arc patch it down to a mac shortly. The concern is
whether parse_url groks svn+ssh and this may be PHP version dependent.

Reviewers: nh, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5726

Details

Committed
Wez Furlong <wez@fb.com>Apr 18 2013, 00:24
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU3ce58de7a74d: Ceated a more flexible lipsum generator
Branches
Unknown
Tags
Unknown

Event Timeline

Wez Furlong <wez@fb.com> committed rPHU80d610d7e2d5: use parse_url() for URI parsing (authored by Wez Furlong <wez@fb.com>).Apr 18 2013, 00:24