Homec4science

Don't treat START TRANSACTION as part of the transaction

Authored by vrana <jakubv@fb.com> on Aug 15 2012, 00:50.

Description

Don't treat START TRANSACTION as part of the transaction

Summary:
We use short transactions and we reconnect if the connection falls down outside transaction.
But START TRANSACTION is treated as part of the transaction so if connection falls while executing this command then we refuse to reconnect.

NOTE: We don't want COMMIT and ROLLBACK put outside transaction because if connection falls before executing them we need to throw away everything.

Test Plan: Created a very large diff with lots of Herald rule evealuating longer than wait_timeout.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3285

Details

Committed
vrana <jakubv@fb.com>Aug 15 2012, 01:04
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUd29816528cfd: Add a very crude spriting pipeline to libphutil
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHU8142ed86f8d8: Don't treat START TRANSACTION as part of the transaction (authored by vrana <jakubv@fb.com>).Aug 15 2012, 01:04