Homec4science

Fix an RRULE bug with day cursors and skipped months

Authored by epriestley <git@epriestley.com> on Sep 28 2016, 16:14.

Description

Fix an RRULE bug with day cursors and skipped months

Summary:
Ref T10747. This rule wasn't quite correct, and got some things like BYMONTH=1,3;INTERVAL=9 wrong.

Instead of resetting the day cursor to 1, we need to move it forward through time in INTERVAL jumps until we get to the next candidate month.

Test Plan: Unit tests now pass.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16619

Details

Committed
epriestley <git@epriestley.com>Sep 29 2016, 00:02
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1a5bbe5971cc: Implement BYSETPOS for YEARLY and MONTHLY RRULES
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU83e9aaa17832: Fix an RRULE bug with day cursors and skipped months (authored by epriestley <git@epriestley.com>).Sep 29 2016, 00:02