Homec4science

Slightly improve the performance of XHPASTTree.

Authored by epriestley <epriestley@phabricator.com> on Feb 10 2011, 23:24.

Description

Slightly improve the performance of XHPASTTree.

The performance breakdown right now is basically (for ~1000 LOC,
on my machine, etc., etc.)

  • 15ms: parse
  • 15ms: json_decode
  • 150ms: building datastructures in PHP

So we're spending an order of magnitude longer transforming the
parse into a usable format than actually parsing the source. This isn't
great but I don't see a clear path forward that doesn't trade off a huge
amount of flexibility. We can port clients to C if we ever need to.

This makes tree construction around 20-30% faster by microoptimzing some
stuff, but it's still not fast.

Details

Committed
epriestley <epriestley@phabricator.com>Feb 10 2011, 23:24
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU4843857a865b: HTTPS support for Conduit, plus a very very basic HTTPSFuture.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <epriestley@phabricator.com> committed rPHU84ae80af2131: Slightly improve the performance of XHPASTTree. (authored by epriestley <epriestley@phabricator.com>).Feb 10 2011, 23:24