Homec4science

Provide explicit remarkup block priorities

Authored by epriestley <git@epriestley.com> on Sep 5 2013, 20:16.

Description

Provide explicit remarkup block priorities

Summary:
D6848 fixed some issues with the %%% literal block syntax, but this had a side effect of breaking list syntax if the blocks were added in a different order than libphutil adds them. It also created an order-dependent issue with the space-only rules in the code block.

To fix this:

  • Add explicit block priorities so the order they're declared in doesn't matter. We did this for inline rules some time ago, and it seems to work well.
  • Explicitly break the input order of blocks to force the priority rules to take effect during unit tests.
  • Split the code and literal blocks apart again, so the space-only logic doesn't run in the literal block. The complexity to keep them inheriting a common parent while separating this logic out didn't seem worthwhile.

Test Plan: The unit tests from D6848 still pass.

Reviewers: andrewjcg, btrahan, chad

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6889

Details

Committed
epriestley <git@epriestley.com>Sep 5 2013, 20:16
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU139a2f2362af: Fix literal block
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU84cac75fbcc7: Provide explicit remarkup block priorities (authored by epriestley <git@epriestley.com>).Sep 5 2013, 20:16