Homec4science

Ensure empty lines do not appear with large widths on last column of…

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Jan 12 2015, 03:07.

Description

Ensure empty lines do not appear with large widths on last column of PhutilConsoleTable

Summary:
If the last column has a large width, it will space out the content of the last column even if no borders are shown. This causes empty lines to appear (that have no content).

Instead, no spacing should be performed on the data of the last column if the column is left aligned and no borders are shown. Long data in the last column will wrap in the terminal (as it would anyway), but rows with short data won't cause empty lines.

Test Plan: Tested under Omni.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11328

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Jan 12 2015, 03:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU698792750d4d: Prevent error in PhutilArgumentParser when not using standard options
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHU8a879e7e549a: Ensure empty lines do not appear with large widths on last column of… (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Jan 12 2015, 03:07