Homec4science

Merge PhutilGitURI into PhutilURI

Authored by epriestley <git@epriestley.com> on Jun 13 2016, 14:03.

Description

Merge PhutilGitURI into PhutilURI

Summary:
Ref T11137. This addresses three general issues:

  • From T11137, I recently added a bad typehint.
  • From T11004, we currently have buggy behavior with Git URIs that have relative paths: we convert them into "ssh://" URIs but change the meaning of their paths.
  • Generally, Phabricator has a lot of instanceof-flavored code around URI handling, and this has been a frequent source of errors. See some discussion in T11137. See next revision for changes to Phabricator.

Test Plan: Unit tests; see next revision for field testing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11137

Differential Revision: https://secure.phabricator.com/D16099

Details

Committed
epriestley <git@epriestley.com>Jun 13 2016, 16:20
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU7233ff63f821: Add a "summary" prose diff mode which omits unchanged text
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU8bb124c37de3: Merge PhutilGitURI into PhutilURI (authored by epriestley <git@epriestley.com>).Jun 13 2016, 16:20