Homec4science

Improve handling of gigantic CommandExceptions

Authored by epriestley <git@epriestley.com> on Dec 25 2012, 04:24.

Description

Improve handling of gigantic CommandExceptions

Summary:
See T2193. For some commands (svn log --xml ...), output may be very large:

  • Truncate the maximum length of exception messages.
  • Summarize outputs in CommandExceptions.

Test Plan: Added execx('cat /usr/share/dict/words && exit 1') to a controller, loaded page. Saw a reasonbly-sized exception onscreen and in the logs.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2193

Differential Revision: https://secure.phabricator.com/D4280

Details

Committed
epriestley <git@epriestley.com>Dec 25 2012, 04:24
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU69161db9ed33: Respect error_reporting() in error handler
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU8bccf69c7614: Improve handling of gigantic CommandExceptions (authored by epriestley <git@epriestley.com>).Dec 25 2012, 04:24