Homec4science

Improve performacne of PhutilSymbolLoader

Authored by epriestley <git@epriestley.com> on Nov 14 2013, 02:07.

Description

Improve performacne of PhutilSymbolLoader

Summary: Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan: 650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7584

Details

Committed
epriestley <git@epriestley.com>Nov 14 2013, 02:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU4ed7dc0489ee: Mark build_xhpast.sh as a bash script, too
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU8c4c27f41bf6: Improve performacne of PhutilSymbolLoader (authored by epriestley <git@epriestley.com>).Nov 14 2013, 02:07