Homec4science

Improve remarkup performance (libphutil)

Authored by epriestley <git@epriestley.com> on Apr 1 2013, 21:06.

Description

Improve remarkup performance (libphutil)

Summary:
As we've moved more logic post-cache, we've started paying a higher price for it. Reorganize some bits of the rendering pipeline so we do less work.

Mostly, this just means that we don't call setEngine() unnecessarily 20,000 times, and don't make multiple postprocessing passes for rules in more than one block.

Test Plan: Unit tests; profiled a 75% reduction of cost in Conpherence.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5511

Details

Committed
epriestley <git@epriestley.com>Apr 1 2013, 21:06
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU9c62fae818fa: Improve FileFinder on Windows
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU8d38e4cf3c88: Improve remarkup performance (libphutil) (authored by epriestley <git@epriestley.com>).Apr 1 2013, 21:06