Homec4science

Speed up text markup for test results

Authored by Peng Li <pengli@fb.com> on Dec 3 2013, 19:51.

Description

Speed up text markup for test results

Summary: Recently there are quite a few diffs hitting timeout when loaded in phabricator page. The reason is that those tests have huge amount of test results and it takes more than two minutes to finish rendering the user data part of the test results. And more than 90 percent of the time was spending on the shouldMergeBlocks calls. There is some unnecessary work in that function, especially first concatenate the lines and then split it using regex, which is a time killer.

Test Plan: Load D1071019. It has more than 15k test results and always times out before. Now it loads in about 5 seconds. Click on 'show all test results' seems to bring up all the test results in right format.

Reviewers: JoelB, lifeihuang, epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7690

Details

Committed
epriestley <git@epriestley.com>Dec 3 2013, 19:51
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUdeed2a5e8e6a: Make it safe to call ExecFuture->resolveKill() after process resolution
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU900e44191d52: Speed up text markup for test results (authored by Peng Li <pengli@fb.com>).Dec 3 2013, 19:51