Homec4science

Fix an issue where all-day events had durations applied incorrectly

Authored by epriestley <git@epriestley.com> on Nov 28 2016, 16:30.

Description

Fix an issue where all-day events had durations applied incorrectly

Summary:
Ref T11816. User-visible bug here was that availability dots (away/busy) for all-day events might not appear correctly if the viewer timezone and event timezone differ.

Underlying issue was that when adding a duration (one day) to an all-day event datetime, we incorrectly used the viewer timezone as part of the calculation.

Instead, base the calculation on a clone of the event with no viewer timezone.

Test Plan:

  • Added failing unit test, made it pass.
  • Saw proper availability dots for all-day events in Phabricator.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11816

Differential Revision: https://secure.phabricator.com/D16953

Details

Committed
epriestley <git@epriestley.com>Nov 28 2016, 17:39
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU42d7ebd477f9: Support using the Porter stemmer when compiling search queries
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9128fb722671: Fix an issue where all-day events had durations applied incorrectly (authored by epriestley <git@epriestley.com>).Nov 28 2016, 17:39