Homec4science

Fix problems with QueryFuture in HPHP

Authored by vrana <jakubv@fb.com> on Feb 21 2013, 23:38.

Description

Fix problems with QueryFuture in HPHP

Summary:
fb_parallel_query() has a weird semantics for indexing results.
Also, it doesn't support queries with different columns.
mysql_fetch_result() raises warning if there's an error.

Test Plan:

$futures = array(
  new QueryFuture($conn, 'SELECT 1'),
  new QueryFuture($conn, 'SELECT 2 FROM x'),
  new QueryFuture($conn, 'DO 3'),
);
foreach (Futures($futures) as $future) {
  try {
    $future->resolve();
    print_r($future->resolve());
  } catch (Exception $ex) {
    echo $ex->getMessage()."\n";
  }
}

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5057

Details

Committed
vrana <jakubv@fb.com>Feb 21 2013, 23:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU17f4c313e34d: Introduce QueryFuture
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHU93fa62a55d54: Fix problems with QueryFuture in HPHP (authored by vrana <jakubv@fb.com>).Feb 21 2013, 23:49