Homec4science

Support loading v2 libraries in libphutil

Authored by epriestley <git@epriestley.com> on May 30 2012, 23:18.

Description

Support loading v2 libraries in libphutil

Summary:

  • When loading a v2 library, load all its functions.
  • When loading a library, build the classtree at load time instead of when we run a PhutilSymbolLoader query with setAncestorClass. This is slightly less efficient for the common case (zero calls), but simpler.
  • Ignore phutil_require_module() calls that load v2 library modules, so a v1 library can continue to reference a v2 library.
  • Load symbols in v2 libraries by loading the appropriate files.

Test Plan: Converted libphutil, arcanist and phabricator to v2, one at a time. Loaded stuff in Phabricator.

Reviewers: vrana, nh, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1103

Differential Revision: https://secure.phabricator.com/D2587

Details

Committed
epriestley <git@epriestley.com>May 30 2012, 23:18
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUad125784f6ed: Increase default HTTP/Conduit timeouts to 5 minutes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9674d62b1540: Support loading v2 libraries in libphutil (authored by epriestley <git@epriestley.com>).May 30 2012, 23:18