Homec4science

Fix an issue where messages may not be processed by PhutilConsoleServer after…

Authored by epriestley <git@epriestley.com> on Aug 6 2012, 15:18.

Description

Fix an issue where messages may not be processed by PhutilConsoleServer after the client exits

Summary:
When we call update(), it may move messages into the read() buffer but we won't process them right now. Process messages after update().

Also improve the correctness of the flush() implementation.

See D2841.

Test Plan: Ran test script with 4-second linter child, got 4 messages on stdout.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3152

Details

Committed
epriestley <git@epriestley.com>Aug 6 2012, 15:18
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU4477e46dd83a: Document %Ls in `csprintf()`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9a78ad168935: Fix an issue where messages may not be processed by PhutilConsoleServer after… (authored by epriestley <git@epriestley.com>).Aug 6 2012, 15:18