Homec4science

Raise an exception if LDAP search fails

Authored by epriestley <git@epriestley.com> on Dec 2 2013, 20:25.

Description

Raise an exception if LDAP search fails

Summary: Currently, we assume search will always succeed if bind succeeds, but this isn't true in the wild. We don't have a root cause yet, but blunt this error into something vaguely useful rather than passing null to an array typehint and failing later and less usefully.

Test Plan: Used bin/auth ldap.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7679

Details

Committed
epriestley <git@epriestley.com>Dec 2 2013, 20:25
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU8ebecbf192fa: Fix daemons erroring on already closed `STDOUT` and `STDERR`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9b2211b4ca72: Raise an exception if LDAP search fails (authored by epriestley <git@epriestley.com>).Dec 2 2013, 20:25