Homec4science

Fix waitForMessage() to always throw when the connection is closed

Authored by epriestley <git@epriestley.com> on Jun 8 2012, 07:13.

Description

Fix waitForMessage() to always throw when the connection is closed

Summary: See D2663. Currently, this method sometimes returns implicit null and sometimes throws on a closed connection. Make it always throw.

Test Plan: Reasoned about program behavior.

Reviewers: csilvers

Reviewed By: csilvers

CC: aran

Differential Revision: https://secure.phabricator.com/D2676

Details

Committed
epriestley <git@epriestley.com>Jun 8 2012, 07:13
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU22fa96e6042b: PhutilChannel, a stream/pipe I/O wrapper
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9e1298c45a56: Fix waitForMessage() to always throw when the connection is closed (authored by epriestley <git@epriestley.com>).Jun 8 2012, 07:13