Don't consider strings with variables to be static
a9e581f6488f
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on May 31 2015, 02:22.

Description

Don't consider strings with variables to be static

Summary: This is related to T8049. Maybe I am misinterpreting what the evalStatic method is meant to do, but I don't think that evalStatic should work on strings which contain interpolated variables.

Test Plan: Unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D13031

Details

Committed

Joshua Spence <josh@joshuaspence.com>

May 31 2015, 02:22

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUd9af980c7de3: Change monospace text formatting

Branches

Unknown

Tags

Unknown

Reverted By

rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static"

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUa9e581f6488f: Don't consider strings with variables to be static (authored by Joshua Spence <josh@joshuaspence.com>).May 31 2015, 02:22

Diffusion added a reverting change: rPHU9a21607bf50b: Revert "Don't consider strings with variables to be static".Mar 17 2017, 12:06

Changes (2)

				Path
	M			src/parser/xhpast/api/XHPASTNode.php
	M			src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Don't consider strings with variables to be statica9e581f6488fActions

Description

Details

Event Timeline

Changes (2)

rPHUa9e581f6488f

src/parser/xhpast/api/XHPASTNode.php

src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Don't consider strings with variables to be static
a9e581f6488f
Actions

src/parser/xhpast/api/tests/XHPASTTreeTestCase.php