Homec4science

Use HTTPS keepalives in HTTPSFuture if possible

Authored by epriestley <git@epriestley.com> on Apr 11 2012, 18:49.

Description

Use HTTPS keepalives in HTTPSFuture if possible

Summary: cURL can manage keepalives as long as you reuse the connection. Since this class is synchronous (despite being a "future"), this is pretty easy. Make appropriate adjustments so we can get HTTPS keepalives.

Test Plan: Ran various "arc" commands under --trace with keepalives, observed dramatic performance improvements for calls 2..N.

Reviewers: btrahan, vrana, jungejason

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2204

Details

Committed
epriestley <git@epriestley.com>Apr 11 2012, 18:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU3fa4bfa9bcf8: Improve SSL error message for CURLE_COULDNT_RESOLVE_HOST
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUaac504afbab2: Use HTTPS keepalives in HTTPSFuture if possible (authored by epriestley <git@epriestley.com>).Apr 11 2012, 18:49