Homec4science

Produce correct query strings from PhutilUri regardless of ini settings

Authored by epriestley <git@epriestley.com> on Oct 14 2015, 19:26.

Description

Produce correct query strings from PhutilUri regardless of ini settings

Summary: http_build_query will use the separator set in arg_separator.output. When this is set to &amp; (which happens in various environments) this causes query parameters to have the & doubly encoded.

Test Plan:

-> php -r 'ini_set("arg_separator.output", "&amp;"); echo http_build_query([1, 2, 3], "", "&");'
0=1&1=2&2=3

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14279

Details

Committed
epriestley <git@epriestley.com>Oct 14 2015, 19:26
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU6d1072d17f90: Fix an issue where we infer the wrong type of a vector which mixes scalar types
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUaee76238d694: Produce correct query strings from PhutilUri regardless of ini settings (authored by epriestley <git@epriestley.com>).Oct 14 2015, 19:26