Homec4science

Fix an issue where the first service call on the page may not be marked…

Authored by epriestley <git@epriestley.com> on Jan 8 2013, 18:49.

Description

Fix an issue where the first service call on the page may not be marked complete if it is a kvcache request

Summary: The first call ID we issue is 0. Possibly we should start at 1, but the ID counter is slightly complicated to muck with. Do a strict null test instead.

Test Plan: Loaded a page which did a kvcache hit first, didn't see a darkconsole issue with undefined 'duration' key in service log.

Reviewers: btrahan, codeblock

Reviewed By: codeblock

CC: aran

Differential Revision: https://secure.phabricator.com/D4358

Details

Committed
epriestley <git@epriestley.com>Jan 8 2013, 18:49
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU9ec218f485af: Fix checking for the same name in tree
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUaf53a5ff0332: Fix an issue where the first service call on the page may not be marked… (authored by epriestley <git@epriestley.com>).Jan 8 2013, 18:49