Homec4science

Add dirty detection and fix a bug in SpriteSheet

Authored by epriestley <git@epriestley.com> on Nov 27 2012, 21:56.

Description

Add dirty detection and fix a bug in SpriteSheet

Summary:

  • I had some W vs H mixed up, fix that.
  • Allow sheets to detect when they need to be regenerated (any source file, rule, dimension, or position has changed) so we don't need to do extra work.

Test Plan: Generated sheets with non-square icons without hitting layout bugs. Ran sprite generation and saw only dirty sheets be picked up for regen.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4031

Details

Committed
epriestley <git@epriestley.com>Nov 27 2012, 21:56
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1237f0e55cdc: Update…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUafb6f0861145: Add dirty detection and fix a bug in SpriteSheet (authored by epriestley <git@epriestley.com>).Nov 27 2012, 21:56