Parse most `[name](href)` Markdown-style links in Remarkup
b03bdc33a4a1
Actions

Authored by epriestley <git@epriestley.com> on May 8 2013, 03:48.

Description

Parse most [name](href) Markdown-style links in Remarkup

Summary: Markdown has [name](href)-style links which we currently don't parse because they can occur naturally in discussions of source code (instead, we support Mediawiki-style links). Apply a few heuristics to reject likely accidental matches and support reasonable forms of this style. Ref T2849.

Test Plan: Added unit tests.

Reviewers: btrahan, jevripio

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2849

Differential Revision: https://secure.phabricator.com/D5857

Details

Committed

epriestley <git@epriestley.com>

May 8 2013, 03:48

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU6471cc293043: Process Markdown-style headers in Remarkup

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb03bdc33a4a1: Parse most `[name](href)` Markdown-style links in Remarkup (authored by epriestley <git@epriestley.com>).May 8 2013, 03:48

Changes (4)

				Path
	A			src/markup/engine/__tests__/remarkup/link-alternate.txt
	M			src/markup/engine/__tests__/remarkup/link-square.txt
	M			src/markup/engine/__tests__/remarkup/simple-table-with-link.txt
	M			src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php