Homec4science

Allow prose and code diffs to use different smoothing

Authored by epriestley <git@epriestley.com> on Jun 7 2016, 22:41.

Description

Allow prose and code diffs to use different smoothing

Summary:
Ref T7643. The prefix/suffix smoothing affected code diffs, and I think it's worse for them overall.

Generally, code has fewer real "words" than prose does. For example, if ($x) { or $x = ($y && $z); are not "words", and it's correct to highlight very limited parts of them.

Add separate "full" and "internal" smoothing modes for prose and code, respectively. I'll follow up by adjusting arcanist and phabricator.

Test Plan: arc unit --everything

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7643

Differential Revision: https://secure.phabricator.com/D16073

Details

Committed
epriestley <git@epriestley.com>Jun 7 2016, 23:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU6d1eea50fb9a: Improve prose diff smoothing rules for whitespace and prefix/suffix changes
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb11a344ba571: Allow prose and code diffs to use different smoothing (authored by epriestley <git@epriestley.com>).Jun 7 2016, 23:07