Homec4science

Allow "+" to remain unescaped by csprintf('%R', ...)

Authored by epriestley <git@epriestley.com> on May 11 2016, 01:56.

Description

Allow "+" to remain unescaped by csprintf('%R', ...)

Summary:
Ref T10923. Currently, when we %R ("readable") escape SVN SSH URIs (svn+ssh://...), they get quoted because they contain a +.

However, they don't need to be quoted, since + is not a special character in the shell.

Test Plan:

  • Added and ran test cases.
  • Viewed SVN in Diffusion, saw unquoted checkout URI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10923

Differential Revision: https://secure.phabricator.com/D15882

Details

Committed
epriestley <git@epriestley.com>May 11 2016, 15:39
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU180f0999d094: Fix LiskMigrationIterator scaling in O(n^2)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb25e0477b280: Allow "+" to remain unescaped by csprintf('%R', ...) (authored by epriestley <git@epriestley.com>).May 11 2016, 15:39