Homec4science

Move XHPAST build script to PHP

Authored by Joshua Spence <josh@joshuaspence.com> on Feb 3 2015, 20:59.

Description

Move XHPAST build script to PHP

Summary:
Currently, building XHPAST from within PHP involves running PhutilXHPASTBinary::build(), which executes the ./scripts/build_xhpast.sh script, which then calls make. Instead, we can bypass ./scripts/build_xhpast.sh and call make directly from PhutilXHPASTBinary::build(). This feels a lot cleaner.

I have retained the ./scripts/build_xhpast.sh script, although it is really a PHP file now. I was considering renaming it to build_xhpast.php, but decided to leave it as is for backwards compatibility.

Test Plan:

> ./scripts/build_xhpast.sh
Build successful!

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11629

Details

Committed
Joshua Spence <josh@joshuaspence.com>Feb 3 2015, 20:59
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU2bf861366bea: Drop explicit version check for flex
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUb2783c6314c2: Move XHPAST build script to PHP (authored by Joshua Spence <josh@joshuaspence.com>).Feb 3 2015, 20:59