Homec4science

Build XHPAST earlier in the stack

Authored by Joshua Spence <josh@joshuaspence.com> on Feb 2 2015, 21:56.

Description

Build XHPAST earlier in the stack

Summary:
Currently, the PhutilLibraryMapBuilder will fail in an obscure way if the XHPAST binary is not built. The issue is that phutil_symbols.php will attempt to build the XHPAST binary, and this will happen eight times concurrently. Ultimately, this will fail with:

<libphutil>/scripts/build_xhpast.sh: line 24: ./xhpast: Text file busy

Test Plan: See D11528.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11627

Details

Committed
Joshua Spence <josh@joshuaspence.com>Feb 2 2015, 21:57
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1d6dcad840ca: Use `PhutilXHPASTBinary` methods
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUb2806977f6aa: Build XHPAST earlier in the stack (authored by Joshua Spence <josh@joshuaspence.com>).Feb 2 2015, 21:57