Homec4science

Shorten strings in PhutilReadableSerializer::printShort()

Authored by epriestley <git@epriestley.com> on Dec 17 2012, 01:27.

Description

Shorten strings in PhutilReadableSerializer::printShort()

Summary: We currently don't shorten strings, which can cause functions like "insert_into_database($giant_block_of_data)" to produce enormous and almost-certainly-useless logs. Shorten overly-long strings.

Test Plan: Threw an exception from f(str_repeat('y', 1024 * 1024)), verified the resulting trace wasn't a gigantic mess.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2193

Differential Revision: https://secure.phabricator.com/D4209

Details

Committed
epriestley <git@epriestley.com>Dec 17 2012, 01:27
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUd4987ba5ade9: Display database name in connection profiler
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb311073895aa: Shorten strings in PhutilReadableSerializer::printShort() (authored by epriestley <git@epriestley.com>).Dec 17 2012, 01:27