Homec4science

Improve CA bundle handling for libphutil / HTTPSFuture

Authored by epriestley <git@epriestley.com> on Feb 19 2012, 18:31.

Description

Improve CA bundle handling for libphutil / HTTPSFuture

Summary: On (some?) Windows systems and some non-Windows systems, cURL doesn't
have a builtin CA bundle. Provide some reasonable mechanisms to give cURL a
valid CA bundle.

Test Plan: I was only able to test this partially because I don't have a
self-signed keypair handy or really know how to generate one. @s and @koolvin,
you both reported issues with this -- can you let me know if this patch
addresses them? In the self-signing case, you'll need to create a "custom.pem"
file with your CA public key (I guess?) in it, perhaps by copying "default.pem"
and then appending it.

Reviewers: Koolvin, s, btrahan

Reviewed By: Koolvin

CC: aran, epriestley, jungejason

Maniphest Tasks: T537

Differential Revision: https://secure.phabricator.com/D1629

Details

Committed
epriestley <git@epriestley.com>Feb 19 2012, 18:31
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUe8bfe38febb4: Add nested and ordered lists to Remarkup
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb787dce1d902: Improve CA bundle handling for libphutil / HTTPSFuture (authored by epriestley <git@epriestley.com>).Feb 19 2012, 18:31