Homec4science

Don't let <span> cross lines when highlighting Remarkup

Authored by epriestley <git@epriestley.com> on Apr 18 2012, 19:11.

Description

Don't let <span> cross lines when highlighting Remarkup

Summary:
If a layer above us wraps each line in some other element (like Paste or Differential) we'll end up with invalid markup if a highlighted element crosses a newline.

Instead, before we hit a newline, add a </span> and resume the span afterwards.

Test Plan: Created a paste with an ... link spanning a newline, got correct highlighting.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2261

Details

Committed
epriestley <git@epriestley.com>Apr 18 2012, 19:11
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU4360da874f40: Centralize highlighter fallback
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUbef1b2e7fa02: Don't let <span> cross lines when highlighting Remarkup (authored by epriestley <git@epriestley.com>).Apr 18 2012, 19:11