Homec4science

Minor improvement to XHPASTSyntaxErrorException message

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 17 2014, 23:33.

Description

Minor improvement to XHPASTSyntaxErrorException message

Summary: Trim trailing newline from exception message.

Test Plan:
Before

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4\n",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

After

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9961

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 17 2014, 23:33
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1f274ecd632b: Minor changes to `phutiltestlib`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUc3d285a9f74b: Minor improvement to XHPASTSyntaxErrorException message (authored by Joshua Spence <josh@joshuaspence.com>).Jul 17 2014, 23:33