Homec4science

Various minor improvements to the `xsprintf` functions

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 1 2014, 16:06.

Description

Various minor improvements to the xsprintf functions

Summary:

  • Renamed Phutil*sprintfTestCase classes to use proper camel case.
  • Added some type hints for function parameters, where appropriate.
  • Use more specific (SPL) Exception types, where appropriate.
  • Change ## to \` in comments.
  • Wrap functions in @{function:...} when they appear in comments.

Test Plan: arc unit still works.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9788

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 1 2014, 16:06
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb2903bea0271: Test cases should extend from `PhutilTestCase`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUc6b75f3ffacf: Various minor improvements to the `xsprintf` functions (authored by Joshua Spence <josh@joshuaspence.com>).Jul 1 2014, 16:06