Homec4science

Use new format for docblock specials when parsing symbols

Authored by Mike Riley <mikeriley@yelirekim.com> on Sep 2 2016, 06:45.

Description

Use new format for docblock specials when parsing symbols

Summary: Fixes T11575. Before, specials used to be separated by newlines, now they are returned as an array for us, or returned as a single value for us. Casting the result to an array is the minimum amount of disruption we can incur here to keep the existing logic in place and provide the same values.

Test Plan:

  • deleted my src/.phutil_module_cache from arcanist, libphutil and phabricator
  • ran arc liberate src in all of those places
  • ran all of their unit tests
  • saw all tests pass and no modifications made to __phutil_library_map__.php for any of the libraries

Reviewers: #blessed_reviewers, epriestley, joshuaspence

Reviewed By: #blessed_reviewers, epriestley, joshuaspence

Subscribers: epriestley

Maniphest Tasks: T11575

Differential Revision: https://secure.phabricator.com/D16484

Details

Committed
Mike Riley <mikeriley@yelirekim.com>Sep 2 2016, 14:05
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU491ebc74d816: Properly Set Host Header in Conduit Client
Branches
Unknown
Tags
Unknown

Event Timeline

Mike Riley <mikeriley@yelirekim.com> committed rPHUc8b76485ef84: Use new format for docblock specials when parsing symbols (authored by Mike Riley <mikeriley@yelirekim.com>).Sep 2 2016, 14:05